If you try to test the pump, there is one thing that will sneak by you.
Most manuals give a flow rate.
So many ounces in so many seconds.
In 99% of the times, if it passes that, its good. Its that other 1% that will sneak up and bite you.
It needs to pass a deadhead pressure test too.
I worked on one that ran great, idled fine, but would drop dead on you when you tried to pass someone.
Tested the volume flow twice, rebuilt the carb, no good.
Take it out on the highway, punch it to pass, and it would just run out of gas about halfway past the car.
Finally rigged up a pressure setup, and it had almost no pressure. New pump cured it.
I ate the core, because I wanted to know what the heck was going on.
Turned out the intake valve had popped out of its socket. It would flow enough all day long, but did not develop any pressure.
After that, the few times I have tested pumps, I have always done both flow and pressure.
Of course, most times with the cheaper pumps, I just toss a new pump at it.